chore: fix modern npm and Windows dev workflow#352
Open
JCDuann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the local development workflow work reliably with modern npm and on Windows:
npm testscript alias while preserving the existingnpm run testsrm -rfin build scripts withrimrafso build cleanup works cross-platformprepublishlifecycle script toprepublishOnlyand adds an explicitbuildscriptoverridesand Yarnresolutionsglobal.navigatorin a way that works on modern Node versionsWhy
On a clean Windows checkout with modern npm/Node:
npm installwas invokingprepublish, then failing becausermis not available on Windows.npm testwas missing.exports.global.navigatoras a getter, so direct assignment failed intest/setup.js.Verification
npm install --legacy-peer-deps --package-lock=falsenpm test-> 2102 passingnpm run build-cjs