fix: root typing use alias when available - #477
Open
krazibit wants to merge 1 commit into
Open
Conversation
jasonkuhrt
approved these changes
Aug 6, 2020
jasonkuhrt
left a comment
jasonkuhrt
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Can you please add a test? Then can merge. Otherwise we'll do it when we can.
jasonkuhrt
suggested changes
Aug 6, 2020
jasonkuhrt
left a comment
jasonkuhrt
left a comment
Contributor
There was a problem hiding this comment.
For clarity setting this to changes requested.
Author
|
Sure, would add a test for it in a bit |
Contributor
|
@krazibit ping |
Author
|
sorry @jasonkuhrt , been a bit busy the past weeks, would dedicate some time to add the test over the weekend, cheers |
Collaborator
|
Up! |
Contributor
|
@Weakky @tgriesser do we want this before 1.0? |
Member
|
Yes. I might fix this myself while renaming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root typing use alias when available