Repository navigation
fix: avoid duplicate errors for external fields - #337
Closed
kamilkisiela wants to merge 1 commit into
Closed
kamilkisiela wants to merge 1 commit into
kamilkisiela wants to merge 1 commit into
Conversation
An `@external` declaration mirrors a field it does not own, so it does not take part in merging that field's type - `object-type.ts` already excludes it when computing `fieldState.type`. `ExternalTypeMismatchRule` then compares each external declaration against the merged type, but `FieldsOfTheSameTypeRule` counted them as merge participants too, so a single disagreement surfaced under both codes. Skip external declarations in the field type merge check, except on key fields, which `ExternalTypeMismatchRule` skips and would otherwise go unreported. The `isExternal` expression, with its Federation v1 extension caveat, was copy-pasted in three places; extracted as `isExternalInGraph`.
kamilkisiela
force-pushed
the
fix/composition-crash-on-unresolvable-selection-set
branch
from
September 22, 2026 14:23
eac3247 to
b937358
Compare
kamilkisiela
force-pushed
the
fix/no-duplicate-field-type-mismatch-for-external
branch
from
September 22, 2026 14:23
e8f9124 to
6792e0f
Compare
kamilkisiela
changed the title
kamilkisiela
deleted the
fix/no-duplicate-field-type-mismatch-for-external
branch
September 22, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
@externalfield with a different type could report two errorsFIELD_TYPE_MISMATCHandEXTERNAL_TYPE_MISMATCHAn
@externalfield only points to a field owned by another subgraph, so it should not be part of the normal field type check.We now skip external fields there and let
ExternalTypeMismatchRulereport the error instead.Key fields are still checked because
ExternalTypeMismatchRuleskips them.This also moves the Federation v1 external-field check into
isExternalInGraph.