Repository navigation
fix: preserve migration headers after failed commit - #273
Merged
benjie merged 4 commits intoOct 14, 2026
Merged
Conversation
benjie
approved these changes
Oct 14, 2026
benjie
left a comment
Member
There was a problem hiding this comment.
Thanks for spotting the issue! Rather than recreating the text with headers, I've just fixed the issue: use the original text that we read.
Merged
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Summary
When
commitfails,parseMigrationTexthas separated migration headers from the SQL body. Restoring only the body drops the--! Message:header fromcurrent.sql. This change serializes the parsed headers with the body before restoring it.Open PR #262 separately restores
--!includedirectives in this rollback path; this change covers the distinct loss of migration headers.Evidence
--! Message: test-migrationrestoredcurrent.sqlwithout the header.Validation
yarn test:only __tests__/commit.test.ts— 14 passed.yarn prettier:check— passed.Merge Danger
Door: Two-way
Blast Radius: Low
The change applies only to restoring the current migration after a failed commit.