Add tag filtering to Cache.iterkeys - #372
Open
Gonghan-Princess wants to merge 1 commit into
Open
Gonghan-Princess wants to merge 1 commit into
Gonghan-Princess wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieving keys by tag currently requires iterating every key and reading each cached value and tag. Add an optional
tagargument toCache.iterkeysso SQLite filters keys before pagination, without fetching cached values.cache.iterkeys(tag='counter')returns matching keys in the existing database sort order;reverse=Truereverses that order. Omittingtagpreserves iteration over all keys, whiletag=Noneselects untagged keys. Empty and numeric tags remain valid. Iteration still includes expired entries. The existing tag index can be used for non-None tag filters; no schema change is required.Fixes #341.
Validation on Windows / Python 3.12.10:
tagwas unsupported; the existing empty-cache test passed.pytest -n 4— 273 passed, 99.27% coverage (98% required), including the tutorial examples.raw, tag indexes, expired entries, and no value fetches.AI assistance: OpenAI Codex prepared the implementation, tests, documentation, and PR text. A separate Codex agent reviewed the patch; no human review is claimed.