Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940. (The repro in draft #939 should now pass with this change.)
composer.on("sendMessage")crashed withTypeError: Cannot read properties of undefined (reading 'transformer')for any nonmatching method. Root cause is inbranch():filter()calls it without a fallback, and it builtnew TransformerComposer(falseTransformer)withfalseTransformer === undefined— a one-element chain whoseflattenstep blows up onundefined.The fix uses an empty composer (identity pass-through) when no fallback is given, so unmatched calls flow to
previousuntouched.How I verified: new
test/transform.test.ts— a nonmatchinggetMereachespreviousexactly once (fails before with the exact reported TypeError, passes after), plus a matching-method test proving scoped transformers still run. Neighbors (composer,filter) green: 5 files / 78 steps,deno lint+deno fmt --checkclean.