fix: increase robustness for future error handling changes - #963
Merged
Merged
Conversation
There was a dead code path that used wrong time units. This did not affect any bots in practice, but for good measure, we fix this anyway.
KnightNiwrem
approved these changes
Aug 24, 2026
KnightNiwrem
left a comment
KnightNiwrem
left a comment
Member
There was a problem hiding this comment.
Not dead code paths. Video sent to DM instead of here - don't want to accidentally leak anything from my screen. Approved.
Member
Author
|
In fact, this did fix an actual bug for bots that are unable to reach TG in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as we know, this does not fix an actual bug. However, it's still nice to use correct time units even on dead code paths.
Fixes #961.
Closes #960.