fix: make polling startup cancellation-safe - #959
roshnicdave wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 45.52% 42.69% -2.84%
==========================================
Files 19 19
Lines 5520 7383 +1863
Branches 360 497 +137
==========================================
+ Hits 2513 3152 +639
- Misses 3003 4146 +1143
- Partials 4 85 +81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| ok: false, | ||
| error_code: 429, | ||
| description: "Too Many Requests", | ||
| parameters: { retry_after: 0 }, |
There was a problem hiding this comment.
How is this test meaningfully different from the test immediately above it?
If the previous test has established that retry occurs - even in the absence of parameters.retry_after for HTTP 429 - what will we be trying to establish with this test with a parameters.retry_after value of 0?
There was a problem hiding this comment.
sorry, forgot to look over tests! can you review again 🙏
|
I have no idea which issue you ran into with your bot, and this seems to be just a slop contribution. I don't see why I should spend my free time on a review if you don't spend yours on the quality of your contributions. Closing. Feel free to join the chat and convince us otherwise if you actually care about this. |
Fixes cancellation races between start, stop, and shared bot initialization
-Scope polling controllers and stop confirmation to each run
-Cancel pending setup/retry work and ignore stale polling results after a restart