test: reproduce Hono and Next.js webhook reply double encoding - #955
Draft
KnightNiwrem wants to merge 1 commit into
Draft
KnightNiwrem wants to merge 1 commit into
KnightNiwrem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was primarily written by GPT-5.6 Sol xhigh in ChatGPT Work.
Summary
This test-only draft PR adds three CI cases for webhook reply serialization:
stdHttppasses the serialized Bot API request through unchanged.Honoapplication..json(value)serialization contract.All three cases use the same shared grammY webhook reply path and the same payload:
{"method":"sendMessage","chat_id":1,"text":"hello"}What this demonstrates
The passing
stdHttpcontrol rules out the shared webhook reply envelope as the source of the corruption: it receives and returns the expected serialized JSON unchanged.The Hono and Next.js cases then fail in their adapter-specific response paths. Both produce a JSON string literal instead of a Bot API request object:
"{\"method\":\"sendMessage\",\"chat_id\":1,\"text\":\"hello\"}"The Hono case uses the framework itself. The Next.js response double applies
JSON.stringify(value), matching the behavior ofNextApiResponse.json.Current CI result
The Ubuntu test job records the intended result:
Both failures show the extra outer quotes and escaped inner JSON. The rest of the webhook-reply tests continue to pass.
The separate CI job confirms that formatting, linting, type-checking, and the publish dry-run all pass.
Purpose
This PR intentionally contains no production fix. It is a minimal reproducer and should not be merged in its current failing state.