fix: always default InlineQueryResultPhoto thumbnail to photo url - #953
Open
KnightNiwrem wants to merge 2 commits into
Open
KnightNiwrem wants to merge 2 commits into
KnightNiwrem wants to merge 2 commits into
Conversation
KnightNiwrem
marked this pull request as ready for review
August 15, 2026 18:32
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bf45c0bbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was primarily written by GPT-5.6 Sol xhigh in ChatGPT Work.
Summary
Ensure that
InlineQueryResultBuilder.photoalways defaultsthumbnail_urlto the photo URL, including when callers supply other options.The builder now:
photo_urloncethumbnail_urlbefore spreadingoptions, so an explicit thumbnail still overrides the defaultthumbnail_urloptional in the builder's options typeWhy
The existing implementation puts the default thumbnail inside the default value of the entire
optionsparameter. JavaScript only evaluates that default whenoptionsis omitted completely. Passing an object such as{ caption: "cap" }therefore drops the documented default thumbnail.This was fixed on
mainin #879. This PR ports the same implementation and regression coverage to v2.Verification
thumbnail_urlbefore the changedeno fmt --check src/convenience/inline_query.ts test/convenience/inline_query.test.tsdeno lint src/convenience/inline_query.ts test/convenience/inline_query.test.tsdeno check --no-config src/convenience/inline_query.ts