fix: use correct options for chat permissions - #952
Open
KnightNiwrem wants to merge 1 commit into
Open
KnightNiwrem wants to merge 1 commit into
KnightNiwrem wants to merge 1 commit into
Conversation
KnightNiwrem
marked this pull request as ready for review
August 15, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was primarily written by GPT-5.6 Sol xhigh in ChatGPT Work.
Summary
Replace the administrator-right fields currently exported as
ALL_CHAT_PERMISSIONSwith the actual fields fromChatPermissions.This also:
can_react_to_messagesandcan_edit_tagpermissionssatisfies ChatPermissionsto reject unrelated fieldsChatPermissionssectionWhy
ALL_CHAT_PERMISSIONSis intended for calls such asrestrictChatMemberto lift all restrictions from a user. The v2 constant currently containsChatAdministratorRightsfields instead, so it does not grant the send permissions described by its documentation.This was fixed on
mainin #874. This PR applies the same correction to v2 while matching the current set of chat permissions.Verification
deno fmt --check src/convenience/constants.tsdeno lint src/convenience/constants.tsdeno check --no-config src/convenience/constants.tstrue