feat: add --inject-label flag to apply, diff, show and export - #2095
feat: add --inject-label flag to apply, diff, show and export#2095colega wants to merge 1 commit into
Conversation
Adds a repeatable --inject-label key=value flag that sets a label on every rendered resource, overriding any pre-existing value. Useful for ad-hoc identification of the resources a given run touched, without editing the Environment's spec.json. Distinct from spec.injectLabels, which only toggles the tanka.dev/environment label used by garbage collection.
|
|
|
|
| return func() map[string]string { | ||
| m := make(map[string]string) | ||
| for _, s := range *injectLabels { | ||
| split := strings.SplitN(s, "=", 2) |
There was a problem hiding this comment.
If we have --inject-label =value, i think it will pass through the format check — SplitN produces ["", "value"] which has length 2. Do we wanna allow it ? I assume the rendering will fail
| for _, s := range *injectLabels { | ||
| split := strings.SplitN(s, "=", 2) | ||
| if len(split) != 2 { | ||
| log.Fatal().Msgf("--inject-label argument has wrong format: `%s`. Expected `key=value`", s) |
There was a problem hiding this comment.
What do you think of adding some additional validation here so that invalid k8s labels don't sneak through?
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
3 participants
Adds a repeatable
--inject-label key=valueflag totk apply,diff,showandexport.The flag sets the given label on every rendered resource, overriding any pre-existing value. This makes it easy to identify, in a cluster, which resources a given run touched (e.g.
--inject-label created-by=alice) without having to edit the Environment'sspec.json.It is intentionally distinct from
spec.injectLabels(the boolean toggling thetanka.dev/environmentlabel) and fromspec.resourceDefaults.labels(which only fills in missing keys). Labels are injected at the singleLoadManifestschokepoint, so all four commands behave consistently.