Repository navigation
chore: add commit sha to the sentry release - #300
Merged
Merged
Conversation
Builds between two version bumps all reported the same release, so Sentry could not tell deploys apart. The deploy workflow now passes GIT_SHA, giving releases like 0.14.0+a05f09e.
spaenleh
force-pushed
the
sentry-release-sha
branch
from
October 10, 2026 11:03
ab1697c to
d674eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sentry release came from the
mix.exsversion only, so every build between two release-please bumps reported the same release. For example, production reported0.11.0from 2026-06-30 to 2026-10-09 across several deploys, and every push tomainreported the last released version.config/prod.exs: release is<version>+<short sha>whenGIT_SHAis set, otherwise the plain versionDockerfile:ARG GIT_SHAjust beforeRUN mix release, so a new commit only invalidates that layer. The Sentry SDK reads:releaseat runtime (nocompile_env)deploy.yaml: passesGIT_SHA=${{ github.sha }}as a build argChecked by evaluating
config/prod.exs:"0.14.0"withoutGIT_SHA,"0.14.0+a05f09e"with it. Not yet checked with a real image build or deploy.Side effect: development deploys create a separate Sentry release per push to
main.