Skip to content

io.codetail library removal from the project and included as a dependency #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Seishin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

io.codetail library removal from the project and included as a dependency #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:1.2.3'
classpath 'com.android.tools.build:gradle:+'

@gowong gowong Apr 28, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be left as a specific version so builds are reliably reproducible.

@Seishin Seishin Apr 28, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.2'
classpath 'com.github.dcendents:android-maven-plugin:1.2'

Expand All @@ -17,5 +17,9 @@ buildscript {
allprojects {
repositories {
jcenter()

maven {
url "https://jitpack.io"
}
}
}
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed Apr 10 15:27:10 PDT 2013
#Mon Apr 25 17:06:04 EEST 2016

@gowong gowong Apr 28, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave this file unchanged? Upgrading the gradle version shouldn't be required.

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-2.2.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-all.zip
9 changes: 6 additions & 3 deletions material-sheet-fab/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
buildToolsVersion "23.0.3"

defaultConfig {
minSdkVersion 14
minSdkVersion 15

@gowong gowong Apr 28, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for bumping this? CircularReveal supports SDK 14.

@Seishin Seishin Apr 28, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anymore. It's now supporting SDK >= 15:
https://github.com/ozodrukh/CircularReveal

@gowong gowong Apr 28, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Their readme still says "Lollipop ViewAnimationUtils.createCircularReveal for everyone 2.3+", but the release notes mention the change in SDK support. In that case, I would rather use an older version of CircularReveal than change the SDK support of this library.

targetSdkVersion 23
}
buildTypes {
Expand All @@ -42,7 +42,10 @@ android {

dependencies {
compile 'com.github.asyl.animation:arcanimator:1.0.0'
compile ('com.github.ozodrukh:CircularReveal:1.3.1@aar') {
transitive = true;
}
}

apply from: 'bintray.gradle'
apply from: 'maven.gradle'
//apply from: 'bintray.gradle'

@gowong gowong Apr 28, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two scripts should be left in

@Seishin Seishin Apr 28, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I just commented them out because I could't build the app.

//apply from: 'maven.gradle'
185 changes: 0 additions & 185 deletions material-sheet-fab/src/main/java/io/codetail/animation/RevealAnimator.java
View file
Open in desktop

This file was deleted.

Loading