ci: add CLI management tests for target, LU, and TPGT commands - #130
Merged
Conversation
Add a new "CLI management test" step to the CI pipeline that exercises the full lifecycle of the new management commands against a running daemon: - list target / list lu / list tpgt (read existing config) - create target -> verify in list - create lu -> verify in list - rm lu -> verify removed - rm target -> verify removed Each step validates output with grep assertions so failures are immediately visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The gotgt CLI client prepends /v{version}/ to API paths, but when built
from untagged commits the version is a git SHA that doesn't match the
server's version route regex. Use curl to hit the API directly instead.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The SCSILu.Path field is not populated during LU creation, so grep for the file path won't work. Use python3 JSON validation to check the array length instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Go's json.Encode outputs null for nil slices. Handle both null and empty array in the LU removal verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list target/list lu/list tpgt(verify existing config is visible)create target-> verify new target appears in listcreate lu-> verify new LU appears in listrm lu-> verify LU is removed from listrm target-> verify target is removed from listgrepassertions for clear pass/failTest plan
🤖 Generated with Claude Code