Skip to content

fix(drive): support shared drive uploads#806

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/drive-upload-shared-drive
Open

fix(drive): support shared drive uploads#806
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/drive-upload-shared-drive

Conversation

@Lubrsy706
Copy link
Copy Markdown

Summary

  • pass supportsAllDrives: true from the drive +upload helper to Drive files.create
  • document that Shared Drive parents are supported automatically
  • add helper coverage for the upload query params

Why

gws drive +upload --parent <shared-drive-folder> currently fails with a Drive 404 because the helper cannot pass supportsAllDrives=true. The raw drive files create --params ... --upload ... path works, but it defeats the purpose of the helper and makes automation harder. Passing the flag is accepted for regular My Drive folders and required for Shared Drive folders.

Fixes #722.

Tests

  • cargo fmt --check
  • cargo test -p google-workspace-cli helpers::drive::tests
  • cargo check -p google-workspace-cli
  • git diff --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: 67e83f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where uploading files to Shared Drive folders via the 'gws drive +upload' command would fail due to missing API parameters. By ensuring the 'supportsAllDrives' flag is passed to the Google Drive API, the helper now correctly handles both standard My Drive and Shared Drive destinations, improving the reliability of the CLI for automated workflows.

Highlights

  • Shared Drive Support: Added the 'supportsAllDrives: true' parameter to the drive upload helper to enable uploads to Shared Drive folders.
  • Documentation: Updated the CLI help text and documentation to clarify that Shared Drive parents are now supported.
  • Testing: Added a new unit test to verify that the upload parameters correctly include the 'supportsAllDrives' flag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added area: skills area: core Core CLI parsing, commands, error handling, utilities labels May 15, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Shared Drives in the Google Workspace CLI drive upload helper. Key changes include the addition of a build_upload_params function that sets the supportsAllDrives parameter to true, updating the execute_method call to include these parameters, and adding a corresponding unit test. Documentation and help text were also updated to reflect this new capability. I have no feedback to provide as there were no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities area: skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gws drive +upload doesn't work with Shared Drive folders

2 participants