fix(feature_store): safely parse bq:// URIs using removeprefix#6771
fix(feature_store): safely parse bq:// URIs using removeprefix#6771mrishi wants to merge 4 commits into
Conversation
The previous implementation used `.lstrip("bq://")`, which greedily
dropped valid characters (like 'b' or 'q') from the beginning of
Google Cloud Project IDs.
Replaced `lstrip` with `removeprefix` to explicitly remove only
the protocol string without mutating the project ID.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Can you sign the CLA? |
Thanks, I had already signed the CLA. A re-scan was pending. Done now. |
|
Thanks, it looks like we lstrip bq in a few other places. Could you also make the change for those files? aiplatform/preview/datasets.py agentplatform/resources/preview/feature_store/offline_store.py |
Done |
Description:
Fixed a bug in
fetch_historical_feature_valueswherebq_uri.lstrip("bq://")was greedily stripping valid characters (such as 'b' or 'q') from the beginning of Google Cloud Project IDs.Replaced
lstripwithremoveprefixto safely and explicitly remove only the protocol string without inadvertently mutating the project ID.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the
mainbranch and this PR will be closed.