Skip to content

bind local callback server to configured host, not all interfaces #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arib06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bind local callback server to configured host, not all interfaces #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/com/google/api/client/extensions/jetty/auth/oauth2/LocalServerReceiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public LocalServerReceiver() {
@Override
public String getRedirectUri() throws IOException {

server = HttpServer.create(new InetSocketAddress(port != -1 ? port : findOpenPort()), 0);
server = HttpServer.create(new InetSocketAddress(host, port != -1 ? port : findOpenPort()), 0);
HttpContext context = server.createContext(callbackPath, new CallbackHandler());
server.setExecutor(null);

Expand Down
22 changes: 22 additions & 0 deletions ...test/java/com/google/api/client/extensions/jetty/auth/oauth2/LocalServerReceiverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,13 @@
import static org.junit.Assert.assertTrue;

import com.google.common.io.CharStreams;
import com.sun.net.httpserver.HttpServer;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.Reader;
import java.lang.reflect.Field;
import java.net.HttpURLConnection;
import java.net.InetSocketAddress;
import java.net.URL;
import java.nio.charset.StandardCharsets;
import org.junit.Test;
Expand All @@ -44,6 +47,25 @@ public void testActualPort() throws IOException {
}
}

@Test
public void testServerBindsToLoopback() throws IOException, ReflectiveOperationException {
LocalServerReceiver receiver = new LocalServerReceiver();

try {
receiver.getRedirectUri();
Field serverField = LocalServerReceiver.class.getDeclaredField("server");
serverField.setAccessible(true);
HttpServer server = (HttpServer) serverField.get(receiver);
InetSocketAddress bound = server.getAddress();
assertFalse(
"callback server must not listen on all interfaces",
bound.getAddress().isAnyLocalAddress());
assertTrue(bound.getAddress().isLoopbackAddress());
} finally {
receiver.stop();
}
}

@Test
public void testRedirectUri() throws IOException {
LocalServerReceiver receiver = new LocalServerReceiver("localhost", -1, null, null);
Expand Down
Loading