chore: setup unit test CI on Bun#8904
Open
pearigee wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the TEST_CMD environment variable in ci/run_single_test.sh to allow overriding the default pnpm test runner. The review feedback correctly identifies an issue where a failure in the prelint step would be ignored due to set +e being active, and suggests chaining the prelint and lint commands with && to ensure proper error propagation.
quirogas
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup presubmit CI on the Bun runtime. This helps us verify our libraries remain Bun compatible!
Note, we are intentionally NOT using Bun as a package manager for this CI. Our monorepo is consolidating around PNPM (for lockfiles and workspaces). Regardless of runtime, we would like to continue doing our dependency management with PNPM.