Skip to content

chore: setup unit test CI on Bun#8904

Open
pearigee wants to merge 3 commits into
mainfrom
pearigee-bun-ci
Open

chore: setup unit test CI on Bun#8904
pearigee wants to merge 3 commits into
mainfrom
pearigee-bun-ci

Conversation

@pearigee

Copy link
Copy Markdown
Contributor

Setup presubmit CI on the Bun runtime. This helps us verify our libraries remain Bun compatible!

Note, we are intentionally NOT using Bun as a package manager for this CI. Our monorepo is consolidating around PNPM (for lockfiles and workspaces). Regardless of runtime, we would like to continue doing our dependency management with PNPM.

@pearigee
pearigee requested a review from a team as a code owner July 17, 2026 20:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the TEST_CMD environment variable in ci/run_single_test.sh to allow overriding the default pnpm test runner. The review feedback correctly identifies an issue where a failure in the prelint step would be ignored due to set +e being active, and suggests chaining the prelint and lint commands with && to ensure proper error propagation.

Comment thread ci/run_single_test.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants