feat(google/spanner/v1): onboard a new library#8860
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/spanner-api package, which provides auto-generated Node.js clients for Cloud Spanner, including database administration, instance administration, and core Spanner services. Feedback on the changes highlights that the generated instance_admin_client.ts file is missing from the PR, and the entrypoint files currently only export InstanceAdminClient instead of all generated clients. Additionally, it is recommended to update the package description in package.json to be more generic and accurate.
quirogas
force-pushed
the
feat/onboard-spanner-api
branch
2 times, most recently
from
July 20, 2026 18:28
3a2150d to
088fa22
Compare
quirogas
force-pushed
the
feat/onboard-spanner-api
branch
from
July 20, 2026 18:36
088fa22 to
0c77488
Compare
quirogas
marked this pull request as ready for review
July 20, 2026 18:58
feywind
reviewed
Jul 20, 2026
feywind
left a comment
feywind
left a comment
Contributor
There was a problem hiding this comment.
Missing the README but otherwise looks good.
quirogas
force-pushed
the
feat/onboard-spanner-api
branch
from
July 20, 2026 20:15
0c77488 to
4c7e035
Compare
feywind
approved these changes
Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.