impl(oauth2): also exclude mtls regional endpoints from RAB#16148
Open
scotthart wants to merge 2 commits into
Open
impl(oauth2): also exclude mtls regional endpoints from RAB#16148scotthart wants to merge 2 commits into
scotthart wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors RegionalAccessBoundaryTokenManager::DoesEndpointRequireToken to check for additional regional endpoint suffixes, specifically .rep.mtls.googleapis.com and .rep.mtls.sandbox.googleapis.com, and adds corresponding unit tests. The reviewer suggested optimizing the static array of suffixes by using std::string_view instead of char const* to enable compile-time string length computation and avoid runtime strlen overhead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16148 +/- ##
==========================================
- Coverage 92.20% 92.19% -0.02%
==========================================
Files 2264 2264
Lines 208864 208872 +8
==========================================
- Hits 192579 192564 -15
- Misses 16285 16308 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the collection of potential regional endpoint suffixes that do not need location tokens to include mtls regional endpoints.