Extend proto-lens API to support serializing the protobuf JSON format - #455
Open
iand675 wants to merge 9 commits into
Open
Extend proto-lens API to support serializing the protobuf JSON format#455iand675 wants to merge 9 commits into
iand675 wants to merge 9 commits into
Conversation
…puile without a hard protobuf compiler dependency
Collaborator
|
Thanks for the change @iand675. You are right that the bootstrap story is a complicated one. We pondered it quite a bit before landing on this one. The reasoning was that people who want to work with protobuf wouldn't consider it a chore to have I'm also semi-blocked on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to support JSON deserialization to the Protobuf models to integrate with a third party system with a large number of protocol buffer definitions, so it was infeasible to hand-write them.
This PR adds support for the serialization formats outlined here: https://protobuf.dev/programming-guides/proto3/#json
I also bumped some dependencies and replaced the
Setup.hscodegen approach for the official protobuf types because the Setup.hs approach absolutely refused to work in the upstream Nix project. I could probably roll it back, but it's nice IMO to be able to use some of the base packages to the ecosystem without having to have the protocol buffer compiler installed.