rl/log_reader: use NumPy view in _add_feature - #572
Open
Arjunmehta312 wants to merge 1 commit into
Open
Conversation
LogReaderTensorValue already exposes a zero-copy NumPy view of the underlying tensor buffer. Extend the protobuf repeated fields from that view instead of iterating through the ctypes-backed sequence. Serialized output is unchanged, and the sequence-example conversion test now asserts byte-for-byte equality. Test: compiler_opt/rl/log_reader_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing zero-copy NumPy view exposed by
LogReaderTensorValuewhen populating protobuf repeated fields in_add_feature.Motivation
LogReaderTensorValuealready provides a NumPy view over the underlyingtensor buffer. Extending protobuf repeated fields from that view avoids
iterating through the ctypes-backed sequence while preserving identical
serialized output.
Validation
SequenceExampleoutput is byte-for-byte identical.compiler_opt/rl/log_reader_test.pywith an additional serialized-output assertion.ruff checkpasses on the modified files.read_log_as_sequence_examples.