Remove special handling for first parameter labels and certain parameter names in Swift interop.#2766
Open
copybara-service[bot] wants to merge 1 commit into
Open
Remove special handling for first parameter labels and certain parameter names in Swift interop.#2766copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…ter names in Swift interop. The J2ObjC translator's @SwiftName Swift name generation no longer omits the first parameter label in method and constructor calls, nor does it treat certain parameter names like "value" as special. This simplifies the naming convention and makes Swift call syntax for Java functions perfectly predictable. PiperOrigin-RevId: 926284345
copybara-service
Bot
force-pushed
the
test_926284345
branch
from
40091ff to
cb671fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove special handling for first parameter labels and certain parameter names in Swift interop.
The J2ObjC translator's @SwiftName Swift name generation no longer omits the first parameter label in method and constructor calls, nor does it treat certain parameter names like "value" as special. This simplifies the naming convention and makes Swift call syntax for Java functions perfectly predictable.