Skip to content

eapp: type make_flags_parser's cls as type[T]. #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

eapp: type make_flags_parser's cls as type[T]. #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Changelog follow https://keepachangelog.com/ format.
* [Fix] `edc.ContextVar`: `default_factory` is now lazily resolved
per-context, so each thread / coroutine gets its own independent
default value.
* `eapp`:
* [Fix] `eapp.make_flags_parser`: annotate `cls` as `type[T]` so the
returned parser is typed as returning `T`, and
`app.run(main, flags_parser=...)` type-checks without suppressions.

## [1.14.0] - 2026-03-04

Expand Down
2 changes: 1 addition & 1 deletion etils/eapp/dataclass_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@


def make_flags_parser(
cls: _DataclassT,
cls: type[_DataclassT],
*,
prog: Optional[str] = None,
description: Optional[str] = None,
Expand Down
Loading