Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Add Chinese translation#12

Closed
xindoo wants to merge 1 commit into
google:masterfrom
xindoo:patch-1
Closed

Add Chinese translation#12
xindoo wants to merge 1 commit into
google:masterfrom
xindoo:patch-1

Conversation

@xindoo

@xindoo xindoo commented Sep 16, 2019

Copy link
Copy Markdown

We are translating this document into Chinese for Chinese developers, and you can also see it on https://eng-practices-cn.xindoo.xyz/

We are translating this document into Chinese for Chinese developers, and you can also see it on https://eng-practices-cn.xindoo.xyz/
@rootsongjc

rootsongjc commented Sep 16, 2019

Copy link
Copy Markdown

I also translated it into Chinese with the same theme. I have finished it.
Github: https://github.com/rootsongjc/eng-practices
Github Pages: https://jimmysong.io/eng-practices/
If you think it's Ok I can submit a PR to merge the Chinese into the upstream.

@xindoo

xindoo commented Sep 16, 2019

Copy link
Copy Markdown
Author

I also translated it into Chinese with the same theme. I have finished it.
Github: https://github.com/rootsongjc/eng-practices
Github Pages: https://jimmysong.io/eng-practices/
If you think it's Ok I can submit a PR to merge the Chinese into the upstream.

Actually, we've built a translation team, and I think we can do better than you.

@adambender

Copy link
Copy Markdown
Contributor

Hey all, code review can be hard enough, lets keep the comments positive please :)

As mentioned on the earlier prI am keen to get a translation if possible but need to find someone at Google who can confirm the quality.

Since the other translation request came first Im going to close this one. Though we might review both at some point.

Thanks for the effort, Im sure this wasn't easy!

@adambender adambender closed this Sep 18, 2019
@xindoo xindoo deleted the patch-1 branch September 20, 2019 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants