fix: ignore vanished cgroup create events - #3933
Open
joejulian wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The raw watcher can receive a directory-create event after a short-lived cgroup has already been removed.
watchDirectorythen returnsENOENT, which currently propagates even though that create/remove ordering is expected.Change
Only the dynamic
ContainerAddpath treatsos.IsNotExistreturned bywatchDirectoryas this race and returns without emitting a container event. Every other watch or read error remains unchanged.Tests
ENOENTerror (ENOTDIR) is still returned.Related historical context: #3464. This narrowly addresses the disappeared-directory create-event race and does not claim to resolve every symptom discussed there.
Validation
libsuitemake testgo vetgolangci-lintv2.6.2gofmt, and diff checks