Skip to content

Treat memory-only NUMA nodes as valid topology - #3931

Merged
dims merged 1 commit into
google:masterfrom
joejulian:fix/memory-only-numa-log-level
Sep 9, 2026
Merged

Treat memory-only NUMA nodes as valid topology#3931
dims merged 1 commit into
google:masterfrom
joejulian:fix/memory-only-numa-log-level

Conversation

@joejulian

Copy link
Copy Markdown
Contributor

Memory-only NUMA nodes are valid Linux topology, but GetNodesInfo currently emits a warning whenever a node has no CPU directories. On systems that intentionally expose memory-only nodes this warning repeats on every topology refresh.

Treat an empty CPU set as a valid memory-only node and move that diagnostic to V(4). Return actual GetCPUsPaths failures instead of conflating them with the valid empty result.

This follows up #3828.

Tests added for:

  • retaining a memory-only NUMA node and its memory data without a warning-level failure path
  • propagating a real CPU-path discovery error

Validation:

  • go test ./utils/sysinfo (from lib/)
  • go test -race ./utils/sysinfo (from lib/)
  • go vet ./... (root and lib/)
  • gofmt -l .

@google-cla

google-cla Bot commented Sep 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joejulian

Copy link
Copy Markdown
Contributor Author

@dims since you touched this file last, would you please take a look?

@dims
dims added this pull request to the merge queue Sep 9, 2026
Merged via the queue into google:master with commit 5bf5d43 Sep 9, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants