fix(models): pass NOT_GIVEN instead of None for system instruction in AnthropicLlm#5337
Open
anmolg1997 wants to merge 1 commit intogoogle:mainfrom
Open
fix(models): pass NOT_GIVEN instead of None for system instruction in AnthropicLlm#5337anmolg1997 wants to merge 1 commit intogoogle:mainfrom
anmolg1997 wants to merge 1 commit intogoogle:mainfrom
Conversation
… AnthropicLlm When no system instruction is set (e.g. during event compaction), system_instruction is None. The Anthropic API rejects None — it expects a str or list of content blocks. This causes a 400 Bad Request when compaction fires via LlmEventSummarizer. Pass NOT_GIVEN (already imported) when system_instruction is None/empty so the parameter is omitted from the API call. Fixes both streaming and non-streaming code paths. Fixes google#5318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When no system instruction is set (e.g. during event compaction via
LlmEventSummarizer),llm_request.config.system_instructionisNone. The Anthropic API rejectsNonefor thesystemparameter — it expects either astr, alistof content blocks, or the parameter to be omitted entirely. This causes a400 Bad Requestcrash whenever compaction fires on a Claude model.Changes
src/google/adk/models/anthropic_llm.pygenerate_content_async(non-streaming path): extractsystembefore the API call, usingNOT_GIVEN(already imported) whensystem_instructionisNoneor empty_generate_content_streaming: same fix for the streaming code pathHow to reproduce
EventsCompactionConfigcompaction_interval=20)LlmEventSummarizercreates anLlmRequestwith no system instruction →system=None→ 400Testing
NOT_GIVENis already used in the same file fortoolsandtool_choiceparameters, so this follows the established patternsystem_instructionis a valid string, behavior is unchangedFixes #5318