build(deps): bump networknt json-schema-validator from v1 to v2.0.1#1486
Open
theyihlin wants to merge 3 commits into
Open
build(deps): bump networknt json-schema-validator from v1 to v2.0.1#1486theyihlin wants to merge 3 commits into
theyihlin wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the json-schema-validator dependency to version 2.0.1 and refactors the Kotlin SDK's Validator class to utilize the updated API. Significant changes include migrating from JsonSchemaFactory to SchemaRegistry, adopting the Schema type, and eliminating the ObjectMapper dependency by validating JSON strings directly. The reviewer suggests optimizing the implementation by reusing shared configuration and registry instances instead of creating redundant local objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades com.networknt:json-schema-validator from 1.5.1 to 2.0.1, aligning it with jackson-databind v2.17, and refactoring the Validator.kt to use the new v2.x API. Runs and verifies all unit/conformance tests successfully.