Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions renderers/angular/src/v0_8/components/audio.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
import {AudioPlayer} from './audio';
import type {AudioPlayerNode} from '../types';
import {Theme} from '../rendering/theming';
import {ChangeDetectionStrategy} from '@angular/core';
import {MessageProcessor} from '../data/processor';
import {Catalog} from '../rendering/catalog';

Expand Down Expand Up @@ -53,11 +52,7 @@ describe('AudioPlayer Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(AudioPlayer, {
set: {changeDetection: ChangeDetectionStrategy.Default},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(AudioPlayer);
component = fixture.componentInstance;
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {Renderer} from '../rendering/renderer';
@Component({
selector: 'a2ui-button',
imports: [Renderer],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<button
[class]="theme.components.Button"
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/card.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import type {CardNode} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';

@Directive({
selector: '[a2ui-renderer]',
Expand Down Expand Up @@ -65,7 +65,6 @@ describe('Card Component', () => {
})
.overrideComponent(Card, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the problem of this change that the google3 defaults are different than the open source ones?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that ChangeDetectionStrategy.Default does not exist in google3. Only Eager and OnPush.
These tests don't really need to override the change detection, so we can just remove these.

imports: [MockRenderer],
},
})
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/column.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import type {ColumnNode} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';

@Directive({
selector: '[a2ui-renderer]',
Expand Down Expand Up @@ -64,7 +64,6 @@ describe('Column Component', () => {
})
.overrideComponent(Column, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/column.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {Renderer} from '../rendering/renderer';
@Component({
selector: 'a2ui-column',
imports: [Renderer],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: `
:host {
display: flex;
Expand Down
7 changes: 1 addition & 6 deletions renderers/angular/src/v0_8/components/datetime-input.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
import {DateTimeInput} from './datetime-input';
import type {A2UIClientEventMessage, DateTimeInputNode} from '../types';
import {Theme} from '../rendering/theming';
import {ChangeDetectionStrategy} from '@angular/core';
import {MessageProcessor} from '../data/processor';
import {Catalog} from '../rendering/catalog';

Expand Down Expand Up @@ -57,11 +56,7 @@ describe('DateTimeInput Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(DateTimeInput, {
set: {changeDetection: ChangeDetectionStrategy.Default},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(DateTimeInput);
component = fixture.componentInstance;
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/icon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import type {IconNode, StringValue} from '../types';
'aria-hidden': 'true',
tabindex: '-1',
},
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: `
:host {
display: block;
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {DynamicComponent} from '../rendering/dynamic-component';

@Component({
selector: 'a2ui-image',
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: `
:host {
display: block;
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import type {ListNode} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';
import {By} from '@angular/platform-browser';

@Directive({
Expand Down Expand Up @@ -65,7 +65,6 @@ describe('List Component', () => {
})
.overrideComponent(List, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {Renderer} from '../rendering/renderer';
@Component({
selector: 'a2ui-list',
imports: [Renderer],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
'[attr.direction]': 'direction()',
},
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/modal.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import type {AnyComponentNode} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';
import {By} from '@angular/platform-browser';

@Directive({
Expand Down Expand Up @@ -72,7 +72,6 @@ describe('Modal Component', () => {
})
.overrideComponent(Modal, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import {By} from '@angular/platform-browser';
import {ChangeDetectionStrategy} from '@angular/core';

describe('MultipleChoice Component', () => {
let component: MultipleChoice;
Expand Down Expand Up @@ -57,13 +56,7 @@ describe('MultipleChoice Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(MultipleChoice, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(MultipleChoice);
component = fixture.componentInstance;
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/row.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import type {RowNode} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';

@Directive({
selector: '[a2ui-renderer]',
Expand Down Expand Up @@ -64,7 +64,6 @@ describe('Row Component', () => {
})
.overrideComponent(Row, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/row.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import type {AnyComponentNode, ResolvedRow, RowNode} from '../types';
@Component({
selector: 'a2ui-row',
imports: [Renderer],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
'[attr.alignment]': 'alignment()',
'[attr.distribution]': 'distribution()',
Expand Down
9 changes: 1 addition & 8 deletions renderers/angular/src/v0_8/components/slider.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import {By} from '@angular/platform-browser';
import {ChangeDetectionStrategy} from '@angular/core';

describe('Slider Component', () => {
let component: Slider;
Expand Down Expand Up @@ -52,13 +51,7 @@ describe('Slider Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(Slider, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(Slider);
component = fixture.componentInstance;
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/surface.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
import {Surface} from './surface';
import {MessageProcessor} from '../data/processor';
import type {AnyComponentNode, Surface as SurfaceType} from '../types';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';

@Directive({
selector: '[a2ui-renderer]',
Expand Down Expand Up @@ -61,7 +61,6 @@ describe('Surface Component', () => {
})
.overrideComponent(Surface, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
3 changes: 1 addition & 2 deletions renderers/angular/src/v0_8/components/tabs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {Tabs} from './tabs';
import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import {Directive, Input, ChangeDetectionStrategy} from '@angular/core';
import {Directive, Input} from '@angular/core';
import {By} from '@angular/platform-browser';

@Directive({
Expand Down Expand Up @@ -77,7 +77,6 @@ describe('Tabs Component', () => {
})
.overrideComponent(Tabs, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
imports: [MockRenderer],
},
})
Expand Down
9 changes: 1 addition & 8 deletions renderers/angular/src/v0_8/components/text-field.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {MessageProcessor} from '../data/processor';
import {Theme} from '../rendering/theming';
import {Catalog} from '../rendering/catalog';
import {By} from '@angular/platform-browser';
import {ChangeDetectionStrategy} from '@angular/core';

describe('TextField Component', () => {
let component: TextField;
Expand Down Expand Up @@ -52,13 +51,7 @@ describe('TextField Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(TextField, {
set: {
changeDetection: ChangeDetectionStrategy.Default,
},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(TextField);
component = fixture.componentInstance;
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/text.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Text Component', () => {
{provide: MarkdownRenderer, useValue: mockMarkdownRenderer},
],
})
// Text component uses ChangeDetectionStrategy.Eager originally!
// Text component uses ChangeDetectionStrategy.OnPush originally!
.compileComponents();

fixture = TestBed.createComponent(Text);
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/text.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ interface HintedStyles {

@Component({
selector: 'a2ui-text',
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<section
[class]="classes()"
Expand Down
7 changes: 1 addition & 6 deletions renderers/angular/src/v0_8/components/video.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
import {Video} from './video';
import type {VideoNode} from '../types';
import {Theme} from '../rendering/theming';
import {ChangeDetectionStrategy} from '@angular/core';
import {MessageProcessor} from '../data/processor';
import {Catalog} from '../rendering/catalog';

Expand Down Expand Up @@ -54,11 +53,7 @@ describe('Video Component', () => {
{provide: Theme, useValue: mockTheme},
{provide: Catalog, useValue: {}},
],
})
.overrideComponent(Video, {
set: {changeDetection: ChangeDetectionStrategy.Default},
})
.compileComponents();
}).compileComponents();

fixture = TestBed.createComponent(Video);
component = fixture.componentInstance;
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_8/components/video.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import type {StringValue, VideoNode} from '../types';

@Component({
selector: 'a2ui-video',
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
@let resolvedUrl = this.resolvedUrl();

Expand Down
2 changes: 1 addition & 1 deletion renderers/web_core/src/v0_8/data/guards.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import assert from 'node:assert';
import * as assert from 'node:assert';
Comment thread
josemontespg marked this conversation as resolved.
import {describe, it} from 'node:test';
import * as guards from './guards.js';

Expand Down
8 changes: 4 additions & 4 deletions renderers/web_core/src/v0_8/data/model-processor.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import assert from 'node:assert';
import * as assert from 'node:assert';
import {describe, it, beforeEach} from 'node:test';
import {A2uiMessageProcessor} from './model-processor.js';
import {TextNode, RowNode} from '../types/types.js';
Expand All @@ -38,7 +38,7 @@ describe('A2uiMessageProcessor', () => {
]);

const surfaces = processor.getSurfaces();
const surface = surfaces.get('s1');
const surface = surfaces.get('s1')!;
assert.ok(surface);
assert.strictEqual(surface.rootComponentId, 'root');
assert.deepStrictEqual(surface.styles, {font: 'Arial'});
Expand Down Expand Up @@ -69,10 +69,10 @@ describe('A2uiMessageProcessor', () => {
},
]);

const surface = processor.getSurfaces().get('s1');
const surface = processor.getSurfaces().get('s1')!;
Comment thread
josemontespg marked this conversation as resolved.
assert.ok(surface);
assert.ok(surface.componentTree);
const root = surface.componentTree as TextNode;
const root = surface.componentTree! as TextNode;
assert.strictEqual(root.id, 'root');
assert.strictEqual(root.type, 'Text');
// The property preserves the literal wrapper
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {CanvasService} from './services/canvas-service';
templateUrl: './a2a-chat-canvas.html',
styleUrl: './a2a-chat-canvas.scss',
imports: [Canvas, Chat],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class A2aChatCanvas {
readonly emptyHistoryTemplate = input<TemplateRef<unknown>>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {ChangeDetectionStrategy, Component, inject, input, resource} from '@angu
templateUrl: './a2a-renderer.html',
styleUrl: './a2a-renderer.scss',
imports: [NgComponentOutlet],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class A2aRenderer {
/** The UiMessageContent to be rendered. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {ChangeDetectionStrategy, Component, computed, inject, input} from '@angu
templateUrl: './a2ui-data-part.html',
styleUrl: './a2ui-data-part.scss',
imports: [Surface],
changeDetection: ChangeDetectionStrategy.Eager,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class A2uiDataPart implements RendererComponent {
/** The UiMessageContent containing the A2A data part with the embedded A2UI message. */
Expand Down
Loading
Loading