fix(github): upgrade go-github to v89 to remove unmaintained openpgp - #1411
Open
alexfalkowski wants to merge 1 commit into
Open
fix(github): upgrade go-github to v89 to remove unmaintained openpgp#1411alexfalkowski wants to merge 1 commit into
alexfalkowski wants to merge 1 commit into
Conversation
Bumps the github and github-ee source drivers from go-github/v39 to v89, which removes golang.org/x/crypto/openpgp from the module graph entirely (go mod why golang.org/x/crypto/openpgp now reports the package is not needed). v89 reworked client construction, so this is an API adaptation rather than a plain version bump: - github: NewClient(*http.Client) becomes options-based NewClient(...ClientOptionsFunc) (*Client, error). The token path uses github.WithAuthToken(...), which drops the driver's direct golang.org/x/oauth2 dependency (now indirect via other sources). - github-ee: NewEnterpriseClient was removed in favor of NewClient(WithHTTPClient(...), WithEnterpriseURLs(...)). URL handling is equivalent; https://host/api/v3 still resolves to /api/v3/. No behavior or URL-contract change for github:// or github-ee://. Fixes golang-migrate#1410.
alexfalkowski
force-pushed
the
fix/go-github-v89
branch
from
July 9, 2026 11:14
d84b702 to
d693172
Compare
Author
|
The
Could a maintainer re-run the failed job when you get a chance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1410.
Bumps the
githubandgithub-eesource drivers fromgo-github/v39tov89, which removesgolang.org/x/crypto/openpgpfrom the module graph entirely —go mod why golang.org/x/crypto/openpgpnow reports the package is not needed.Worth highlighting
github:NewClient(*http.Client)→ options-basedNewClient(...ClientOptionsFunc) (*Client, error). The token path now usesgithub.WithAuthToken(...), dropping the driver's directgolang.org/x/oauth2dependency (now indirect via other sources).github-ee:NewEnterpriseClient(base, upload, httpClient)was removed →NewClient(WithHTTPClient(...), WithEnterpriseURLs(base, upload)). URL normalization is equivalent —parseURLappends the trailing slash before the/api/v3/check, sohttps://host/api/v3still resolves to/api/v3/.github://orgithub-ee://; the content API (GetContents/DownloadContents) is unchanged.