fix: decode percent-encoded path in sqlite database URL - #1406
Open
AlisinaDevelo wants to merge 1 commit into
Open
fix: decode percent-encoded path in sqlite database URL#1406AlisinaDevelo wants to merge 1 commit into
AlisinaDevelo wants to merge 1 commit into
Conversation
Author
|
Checking in on the SQLite URL fix. It decodes percent-encoded path components while preserving query parameters, and Go 1.24 and 1.25 tests, lint, and coverage checks are green. If this still fits the project’s direction, could someone take a look when there’s a chance? I’m happy to rebase or adjust the path handling. |
Author
|
Hey, checking in on the SQLite URL fix—does the path handling need anything else from me before review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1256.
The sqlite driver built its DSN from
purl.String(), which re-encodes the URL path. A database URL likesqlite:///Magic%20Data/db.sqlitewas passed tosql.Openwith the%20intact, so it looked for a literalMagic%20Datafile and failed to connect.Now the DSN is built from the decoded path (still keeping any non-custom query params, e.g. sqlite pragmas). Added a test that opens a DB under a directory with a space in the name.