toolkit: add ContextMenu right-click popup helper#14
Merged
Conversation
The overlay wrapper the widget model lacked around the bare Menu: Popup(x, y) shows a Menu at the cursor, it auto-sizes to its items (widest label + shortcut/chevron, floored), clamps itself inside the surface so it never spills off an edge, forwards an inside-click to the Menu (firing the row's Action and closing via OnClose), and dismisses on any outside-click. Mirrors how DropDown/DatePicker own their pop-ups. 100% coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second pre-1.0 "model edge" item: the overlay wrapper the widget model lacked around the bare
Menu.Popup(x, y)shows aMenuat the cursor; it auto-sizes to its items (widest label + shortcut/submenu-chevron, floored atContextMenuMinW), clamps itself inside the surface so it never spills off an edge, forwards an inside-click to theMenu(firing the row'sActionand closing viaOnClose), and dismisses on any outside-click. Mirrors howDropDown/DatePickerown their pop-ups.Renders through
painter.Painter. 100% coverage;go vetclean; builds on all 6 arches + js/wasm.🤖 Generated with Claude Code