toolkit: add first-class drag-and-drop event kinds#13
Merged
Conversation
Formalises the drag lifecycle the widget model was missing: EventDragStart / EventDragMove / EventDragLeave / EventDrop (appended to the event enum), plus a DragSource / DropTarget interface pair and SplitDropPayload / JoinDropPayload for multi-item payloads carried in Event.Code. DropZone drops its acknowledged synthetic-EventChar seam and now drives its hover cue + OnDrop from the formal events as a DropTarget (accepting any non-empty payload, delivering all newline-separated items). 100% coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalises the drag lifecycle the widget model was missing — the first of the pre-1.0 "model edge" items from the README's Next section.
EventDragStart/EventDragMove/EventDragLeave/EventDrop.DragSource(DragData() string) andDropTarget(AcceptsDrop(payload) bool) — the host contract for discovering which widgets participate.SplitDropPayload/JoinDropPayloadfor multi-item drops carried newline-separated inEvent.Code.EventCharseam and now drives its hover cue +OnDropfrom the formal events as aDropTarget, delivering every dropped item.The only ecosystem consumer (svg gallery) uses DropZone for a static render only, so the behaviour change is contained. 100% coverage;
go vetclean; builds on all 6 arches + js/wasm.🤖 Generated with Claude Code