Skip to content

Improve tearoff support#439

Draft
rmottola wants to merge 2 commits into
masterfrom
improve_tearoff_support
Draft

Improve tearoff support#439
rmottola wants to merge 2 commits into
masterfrom
improve_tearoff_support

Conversation

@rmottola

Copy link
Copy Markdown
Member

No description provided.

@rmottola rmottola requested a review from fredkiefer as a code owner June 17, 2026 00:09
@rmottola rmottola marked this pull request as draft June 17, 2026 00:10
@rmottola

Copy link
Copy Markdown
Member Author

This branch is WIP to have the corresponding branch in back working

Comment thread Source/GSHorizontalTypesetter.m Outdated
@fredkiefer

Copy link
Copy Markdown
Member

I think this is a very nice idea, but it contradicts the Apple documentation where they state that this two values are synonymous. If we still want to make this change we really need to be careful:

  • are these constants used consistently in gui
  • is the window level stored in any NIB files
  • check all the different backends not just x11 in back for usages

And if Apple uses as documented the same value, who is willing to decide that we break compatibility?

@rmottola

Copy link
Copy Markdown
Member Author

I think this is a very nice idea, but it contradicts the Apple documentation where they state that this two values are synonymous. If we still want to make this change we really need to be careful:

* are these constants used consistently in gui

* is the window level stored in any NIB files

* check all the different backends not just x11 in back for usages

And if Apple uses as documented the same value, who is willing to decide that we break compatibility?

Well, Apple does not support X11 since the time of OpenStep on solaris... MacOS does not have tear-off menus since Rhapsody. Thus we have more needs than apple!

We need this information and in the code "tear off" is actually used in distinction of menu, but then it ends being the same thing currently.

I looked around the code, cannot be sure of course this is all what is needed, but it is needed for the corresponding changes in libs-back

rmottola added 2 commits June 30, 2026 21:28
…er level was broken already anyway and WM actually quotes GS values in a vicous circle
@rmottola rmottola force-pushed the improve_tearoff_support branch from 6fbfd45 to fd546bd Compare June 30, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants