Make 'v1' token storage less accessible - #1265
Closed
sirosen wants to merge 1 commit into
Closed
Conversation
This is a small internal change which reduces the size of the ``globus_sdk.token_storage`` top-level interface. It has impact on code completions and the general developer experience when using these legacy tools. A new section is added to the upgrading guide on the changes in names (not previously covered).
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
July 17, 2025 20:55
Member
|
Introducing a |
Member
Author
|
I would accept a suggestion for an alternative naming scheme, e.g. I care about the advertised/documented import paths more than I do about the physical file layout. I think it's mildly relevant that this doesn't introduce the name, it just starts to require it. Only in that I'm not "suggesting" v1. |
Member
Author
|
We want to plan / discuss any rename to handle this, so I'm marking as a draft. It may be superseded. |
sirosen
marked this pull request as draft
July 23, 2025 20:14
Member
Author
|
Closed in favor of #1290 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: This isn't something we've discussed as a team, but I think it aligns with our general naming and deprecation schedule without adding scope-creep to our SDK v4 milestone.
I noted an example which is still showing the 'v1' interface, which I intend to update in a separate follow-up.
This is a small internal change which reduces the size of the
globus_sdk.token_storagetop-level interface.It has impact on code completions and the general developer experience when using these legacy tools.
A new section is added to the upgrading guide on the changes in names (not previously covered).
📚 Documentation preview 📚: https://globus-sdk-python--1265.org.readthedocs.build/en/1265/