Remove the 'UUIDLike' type alias (v4 branch) - #1262
Merged
Merged
Conversation
sirosen
force-pushed
the
fix-type-aliases
branch
4 times, most recently
from
July 16, 2025 19:36
a639732 to
e096fff
Compare
sirosen
marked this pull request as ready for review
July 16, 2025 19:36
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
July 16, 2025 19:36
kurtmckee
previously approved these changes
Jul 16, 2025
This is not strictly necessary and importantly it isn't interpreted as we'd like by Sphinx, so users are seeing the `UUIDLike` name in our docs instead of the union. Use `Union` rather than `UnionType` in tests which have a runtime context.
sirosen
force-pushed
the
fix-type-aliases
branch
from
July 17, 2025 16:30
e096fff to
3eddb61
Compare
kurtmckee
approved these changes
Jul 17, 2025
Member
Author
|
Just for interest, the last logical conflict I had to fix here was Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is based on #1245 and is effectively a cherry-pick of #1258.
Applying this in both places should hopefully reduce conflicts when the branches are merged.
📚 Documentation preview 📚: https://globus-sdk-python--1262.org.readthedocs.build/en/1262/