Add RequestCallerInfo data object to RequestsTransport.request - #1261
Merged
Conversation
* Add RequestCallerInfo class for passing caller context information * Update RetryContext to use caller_info instead of authorizer * Maintain backward compatibility with existing authorizer parameter * Add warning when both caller_info and authorizer parameters differ
m1yag1
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
sirosen
as code owners
July 16, 2025 16:40
sirosen
reviewed
Jul 17, 2025
sirosen
left a comment
sirosen
left a comment
Member
There was a problem hiding this comment.
The intent with that card, although I now see that I did not write it unambiguously, was that we replace authorizer with the new caller info object. Could you update to do so? The lack of a need for backwards compatibility in v4 is why we benefit from doing this now, in particular.
MaxTueckeGlobus
left a comment
MaxTueckeGlobus
left a comment
Contributor
There was a problem hiding this comment.
Just want to quick make a note of this for now, I'll hold off on the main body of my review until Stephen's feedback has been resolved.
kurtmckee
requested changes
Jul 17, 2025
This removes backward compatibility and makes caller_info a required parameter based on PR review feedback. Moves RequestCallerInfo to requests.py.
for more information, see https://pre-commit.ci
sirosen
requested changes
Jul 17, 2025
m1yag1
force-pushed
the
sc-43037-caller-info
branch
from
July 17, 2025 20:13
327e443 to
72a03c8
Compare
sirosen
approved these changes
Jul 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sc-43037
This adds
RequestCallerInfoas an extensible container for caller context information inRequestsTransport.request().The change breaks backward compatibility and replaces the
authorizerparameter while enabling future extensions for additional caller context beyond authorization.RequestCallerInfotakes precedence when both parameters are provided, with a warning logged for conflicting usage.📚 Documentation preview 📚: https://globus-sdk-python--1261.org.readthedocs.build/en/1261/