Conversation
kurtmckee
requested review from
aaschaer,
ada-globus,
derek-globus and
m1yag1
as code owners
July 16, 2025 11:57
kurtmckee
added
the
no-news-is-good-news
sirosen
approved these changes
Jul 16, 2025
sirosen
left a comment
sirosen
left a comment
Member
There was a problem hiding this comment.
I don't know that we need to make sure it stays naive in the example, but it's easier to include the .replace() than it is to think about that. 😁
Member
Author
|
I chose naivete because knowing the timezone can affect string serialization...and you're right, it's easier to do the dumb switcheroo than to reason about the effects of code in a docstring. 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been staring at this while working on another feature and decided to remove it in a separate PR.
This change still results in a timezone-unaware object, which matches what
.utcnow()was producing.📚 Documentation preview 📚: https://globus-sdk-python--1260.org.readthedocs.build/en/1260/