Replace ScopeCollectionType alias with explicit expansion of types - #1259
Merged
Conversation
MaxTueckeGlobus
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
July 15, 2025 21:18
sirosen
approved these changes
Jul 15, 2025
sirosen
left a comment
sirosen
left a comment
Member
There was a problem hiding this comment.
I think keeping the typing test is good.
I see that we're using dict[str, str | Scope | t.Iterable[str | Scope]] in some locations, and we should examine those as well, after this PR. I think they'll require runtime changes to accept arbitrary mappings and store in dicts, so we'll have to decide whether or not those are correct.
sirosen
reviewed
Jul 15, 2025
| :param iter_scope_strings: If True, scope strings with multiple root scopes are | ||
| :param obj: A scope string, scope object, or an iterable of scope strings | ||
| and scope objects. | ||
| :param split_root_scopes: If True, scope strings with multiple root scopes are |
Member
There was a problem hiding this comment.
By the way, kudos for spotting and fixing this!
sirosen
reviewed
Jul 15, 2025
sirosen
approved these changes
Jul 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sc-41884
Changes
ScopeCollectionTypetype alias.ScopeCollectionTypewith explicitstr | Scope | t.Iterable[str | Scope]type annotations.globus_sdk.scopes.scopes_to_strandglobus_sdk.scopes.scopes_to_scope_list. Since all codepaths that previously supported recursive scope definitions rely on these helpers for scope normalization, this change removes recursive scope support across the entire SDK.tests/unit/scopes/test_scope_normalization.pyverifyingscopes_to_strandscopes_to_scope_listnow raiseTypeErrorfor nested iterables.Note: I opted not to remove
tests/non-pytest/mypy-ignore-tests/scope_collection_type.pyas it still validates there is consistentrequested_scopestyping across the SDK. Happy to remove it though if reviewers feel it's redundant.📚 Documentation preview 📚: https://globus-sdk-python--1259.org.readthedocs.build/en/1259/