Skip to content

Add send_tree and dispatch_tree to support sending iodata - #59

Open
JonasGruenwald wants to merge 1 commit into
gleam-lang:mainfrom
JonasGruenwald:patch-1
Open

JonasGruenwald wants to merge 1 commit into
gleam-lang:mainfrom
JonasGruenwald:patch-1

Conversation

@JonasGruenwald

@JonasGruenwald JonasGruenwald commented Mar 15, 2026 •

Copy link
Copy Markdown

Closes: #58

I can rewrite the test if #57 is merged before this. (Tests have been adjusted)

@jtdowney jtdowney left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, the mock HTTP server for tests was merged in #57. I would recommend rebasing and using it for the test.

Comment thread src/gleam/httpc.gleam Outdated
Comment thread src/gleam/httpc.gleam Outdated
Comment thread test/gleam_httpc_test.gleam Outdated
Comment thread CHANGELOG.md Outdated
@JonasGruenwald

Copy link
Copy Markdown
Author

@jtdowney thanks for having a look!
I've rebased, changed it to use the mock server and gone through your comments :) mind having another look?

Comment thread src/gleam/httpc.gleam Outdated
@JonasGruenwald

Copy link
Copy Markdown
Author

Anything I can do here still? I think I've addressed all comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending string_tree / bytes_tree as body

2 participants