Repository navigation
Add tests #5
Description
At the moment the tests are probably quite thorough because the hit a real API endpoint.
However this means they are somewhat fragile.
Also all the functions are marked as TODO: test
@lpil do you have an idea on how you would like to test these functions?
In magpie I ran tests against a locally running version of httpbin.org however that did add a dependence on docker, which I'm unsure if you want to add as a requirement for contributing. I also haven't played much with github workflows so am unsure what that would take
https://github.com/midas-framework/magpie/blob/master/test/magpie_test.gleam#L12
https://github.com/midas-framework/magpie/blob/master/docker-compose.yml#L24-L27
Activity
lpil commentedon Aug 11, 2020
Those endpoints are intended for public use and are quite reliable. I do not want to add a docker compose dep as it's not an open standard and only works with that specific tool. I'm open to containers as they're less niche and supported by many clients, though I would prefer to have no requirement for additional software being installed (i.e. use existing services, Gleam, or Erlang)
CrowdHailer commentedon Aug 11, 2020
If your happy with those endpoints, which sounds perfectly sensible. I think some of the
todo Testcould be removed?lpil commentedon Aug 11, 2020
jtdowney commentedon Sep 16, 2026
@lpil I think this can be closed now that #57 is merged