Skip to content

Fix Markdown closing fences in automated translation reports - #156

Merged
linmq merged 1 commit into
masterfrom
fix/translation-report-closing-fence
Nov 4, 2026
Merged

linmq merged 1 commit into
masterfrom
fix/translation-report-closing-fence

Conversation

@linmq

@linmq linmq commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Ensure the Markdown closing fence is on its own line when codex-output.json has no trailing newline.
  • Fix both the automated translation PR body and the fallback English-source issue body.

The malformed report in #155 exposed this issue: the generated body ended with the JSON closing brace immediately followed by three backticks, so GitHub displayed the backticks instead of closing the code block.

Validation

  • Python simulation of both report-generation blocks with and without a trailing newline: all four cases passed; closing fences are standalone and embedded JSON remains valid.
  • git diff --check passed.

Assisted-by: Cindy (https://cindy.app)

Add an explicit newline after the Codex JSON report in both PR and fallback issue bodies. Codex output may omit the final newline, causing the Markdown closing fence to be appended to the JSON.

Assisted-by: Cindy (https://cindy.app)
@linmq
linmq merged commit 038bd98 into master Nov 4, 2026
@linmq
linmq deleted the fix/translation-report-closing-fence branch November 4, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants