Conversation
to hold particular bits of the graph
for managing the different types of connections in a structured way
For holding the contextual information of a row
|
@extrawurst Would love your feedback on this :) Quite large. OH! And I just noticed that I removed the missing docs lint, I'll add that back if we agree on this general direction. |
|
LGTM |
| * fix extremely slow status loading in large repositories by replacing time-based cache invalidation with generation counter [[@DannyStoll1](https://github.com/DannyStoll1)] ([#2823](https://github.com/gitui-org/gitui/issues/2823)) | ||
| * fix panic when renaming or updating remote URL with no remotes configured [[@xvchris](https://github.com/xvchris)] ([#2868](https://github.com/gitui-org/gitui/issues/2868)) | ||
| ### Added | ||
| * Now with a graph view! |
There was a problem hiding this comment.
please match the ususal format
|
Being precise here, the only difference I can see in the lack of a bottom connector? Or is there something else?
▰▰▰▰▰
Miles Wirth 🙃
… From: extrawurst ***@***.***>
Sent: 29 March 2026 11:53
To: gitui-org/gitui ***@***.***>
Cc: Miles Wirht ***@***.***>, Author ***@***.***>
Subject: Re: [gitui-org/gitui] Branching (PR #2890)
extrawurst left a comment (gitui-org/gitui#2890)
I think we need to improve the visualization still, this is the same point in time of the history in three different tools: gitui, tig and fork:
<img width="623" height="291" alt="Screenshot 2026-03-29 at 19 50 36" src="https://github.com/user-attachments/assets/a05fed09-ce18-4f55-8915-e143b37b01d3" />
<img width="392" height="326" alt="Screenshot 2026-03-29 at 19 50 27" src="https://github.com/user-attachments/assets/8669dbeb-604b-4d25-ba8c-de5aa701ac95" />
<img width="895" height="227" alt="Screenshot 2026-03-29 at 19 51 51" src="https://github.com/user-attachments/assets/5cf8535b-3ce6-44a2-944d-a33c81c548ce" />
--
Reply to this email directly or view it on GitHub:
#2890?email_source=notifications&email_token=A3MQBNB5QFY6DKIO5JS2ZSD4TFWKZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJVGA4DKNBWGE32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4150854617
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
I am looking forward to this change! By a quick look the source it seems like it works only with merge commits with 2 parents, but commit can have an arbitrary number of parents (see e.g. here). |
|
@VojtaStanek Yes! Octopus merges! That's not covered here. I couldn't find an implementation that handles them in a way that maps well to streaming. They don't crash anything, and happen incredibly rarely. If someone is able to extend what I have here, they're welcome to; but it shouldn't block merging. |
|
No, that's just how they look :sad:.
Good points -- I also wonder if people like the pressed texts to the facets of the branch lines? I could implement that as well.
I think symbols... look cooler; but there are readability improvements we could aim for regardless, that these screenshots are making clear to me. The glyphs could expose be exposed as configuration.
▰▰▰▰▰
Miles Wirth 🙃
… From: Christoph Rüßler ***@***.***>
Sent: 07 April 2026 12:37
To: gitui-org/gitui ***@***.***>
Cc: Miles Wirht ***@***.***>, Author ***@***.***>
Subject: Re: [gitui-org/gitui] Branching (PR #2890)
cruessler left a comment (gitui-org/gitui#2890)
Thanks a lot for getting this started, that’s much appreciated! I just started reviewing the changes, but then I had a few more general questions.
In its current form, I find it hard to see merge commits and how they connect to their respective parents. The image below shows a comparison between this branch and `tig` in the `gitoxide` repository that has quite a few merge commits. Is there anything I need to set up to make merge commits more prominent? Does my terminal font need to have certain glyphs?
Also, in `tig`, vertical lines don’t get cut by horizontal ones, as opposed to `guitar`. I think I like `tig`’s approach better. What do you think?
<img width="3440" height="1412" alt="Screenshot_20260407_212543" src="https://github.com/user-attachments/assets/c224b4a6-6a01-4942-be2f-fef91d63d40a" />
--
Reply to this email directly or view it on GitHub:
#2890 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Not for now.
Also not relevant for now. Lets find a visual style thats a good default and add customization in a later PR. THis one is big enough as is.
I agree with this. we either find better symbols or go for the letter Furthermore I think we should use different colored lines for parallel branches like tig does for more clear separation. |
This was annoying
With color and crosses!
With the updates, the PR is now looking like the above. Is this a better direction? @extrawurst I plan to submit a follow-up PR with selection-based highlighting which I think will clear up the remaining vie |







This Pull Request fixes/closes #81.
It changes the following:
I followed the checklist:
make checkwithout errors