fix: gh aw logs MCP tool fails with 'unable to find git executable in PATH' in agent sandbox

[Copilot]

The gh aw logs MCP tool is unusable in agent sandbox environments (e.g. audit-workflows) because gh run list tries to detect the current repo via git remote, but git is not in PATH inside the agent container.

Changes

• pkg/cli/logs_orchestrator.go: Extracts a applyRepoOverrideFallback helper that, when repoOverride is empty, falls back to GITHUB_REPOSITORY (always set in GitHub Actions). This single assignment propagates through the entire call chain:
  • listWorkflowRunsWithPagination → adds --repo to gh run list
  • downloadRunArtifactsConcurrent → adds --repo to gh run download and artifact API calls

func applyRepoOverrideFallback(repoOverride string) string {
    if repoOverride != "" {
        return repoOverride
    }
    if githubRepo := os.Getenv("GITHUB_REPOSITORY"); githubRepo != "" {
        return githubRepo
    }
    return repoOverride
}

The fallback only activates when no explicit --repo flag is given. gh api calls using {owner}/{repo} template placeholders (fetchJobStatuses, fetchJobDetails) may fail if git is unavailable and GH_REPO is not set externally, but these calls are already non-fatal and return nil on error.

• pkg/cli/logs_repo_fallback_test.go: Unit tests for applyRepoOverrideFallback covering explicit override passthrough, GITHUB_REPOSITORY fallback, and no env vars present.

[!WARNING]

[Copilot]

Pull request overview

Fixes gh aw logs failures in agent sandbox environments where git isn’t available by ensuring gh commands have an explicit repository context.

Changes:

• Add a fallback in DownloadWorkflowLogs to use GITHUB_REPOSITORY when --repo isn’t provided, and set GH_REPO (if unset) for gh api template paths.
• Add a repo-level .mcp.json MCP server configuration for gh aw mcp-server.

Show a summary per file

File	Description
pkg/cli/logs_orchestrator.go	Derives repo context from GITHUB_REPOSITORY when repoOverride is empty; sets GH_REPO to support gh api template placeholders without git.
.mcp.json	Adds MCP server config pointing to gh aw mcp-server.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 3

[Copilot]

This code mutates the process environment by setting GH_REPO. Since DownloadWorkflowLogs is exported and used from unit tests, leaving GH_REPO set for the remainder of the process can create cross-test contamination and unexpected behavior in later commands. Consider capturing the prior GH_REPO value (via os.LookupEnv) and restoring/unsetting it with a defer so the env change is scoped to this invocation while still affecting all gh subprocesses spawned within the function.

Suggested change

	if os.Getenv("GH_REPO") == "" {
	if err := os.Setenv("GH_REPO", repoOverride); err != nil {
	// Non-fatal: the primary listing and download paths use explicit --repo flags.
	// Only gh api calls using {owner}/{repo} template placeholders (e.g. job status
	// queries) will be unable to resolve the repository context.
	logsOrchestratorLog.Printf("Failed to set GH_REPO env var (gh api {owner}/{repo} template calls may fail to resolve repo context): %v", err)
	if _, ghRepoWasSet := os.LookupEnv("GH_REPO"); !ghRepoWasSet {
	if err := os.Setenv("GH_REPO", repoOverride); err != nil {
	// Non-fatal: the primary listing and download paths use explicit --repo flags.
	// Only gh api calls using {owner}/{repo} template placeholders (e.g. job status
	// queries) will be unable to resolve the repository context.
	logsOrchestratorLog.Printf("Failed to set GH_REPO env var (gh api {owner}/{repo} template calls may fail to resolve repo context): %v", err)
	} else {
	defer func() {
	if err := os.Unsetenv("GH_REPO"); err != nil {
	logsOrchestratorLog.Printf("Failed to restore GH_REPO env var after temporary override: %v", err)
	}
	}()

[Copilot]

The new GITHUB_REPOSITORY→repoOverride/GH_REPO fallback is a key behavior change but isn’t covered by tests. Suggest extracting the fallback logic into a small helper and adding a unit test that verifies: (1) repoOverride is populated from GITHUB_REPOSITORY when empty, (2) pre-existing GH_REPO is respected, and (3) GH_REPO is set when absent.

Suggested change

	// DownloadWorkflowLogs downloads and analyzes workflow logs with metrics
	func DownloadWorkflowLogs(ctx context.Context, workflowName string, count int, startDate, endDate, outputDir, engine, ref string, beforeRunID, afterRunID int64, repoOverride string, verbose bool, toolGraph bool, noStaged bool, firewallOnly bool, noFirewall bool, parse bool, jsonOutput bool, timeout int, summaryFile string, safeOutputType string, filteredIntegrity bool, train bool, format string, artifactSets []string) error {
	// When no explicit repo override is given, fall back to GITHUB_REPOSITORY so that
	// `gh run list` and `gh run download` can operate without a git checkout.
	// This is needed in agent sandbox environments (e.g., the audit-workflows agent)
	// where git is not installed but GITHUB_REPOSITORY is set by GitHub Actions.
	// We also set GH_REPO so that `gh api` calls using {owner}/{repo} template
	// placeholders (e.g., fetchJobStatuses, fetchJobDetails) resolve correctly.
	if repoOverride == "" {
	if githubRepo := os.Getenv("GITHUB_REPOSITORY"); githubRepo != "" {
	repoOverride = githubRepo
	logsOrchestratorLog.Printf("Using GITHUB_REPOSITORY env var as repo override: %s", repoOverride)
	if os.Getenv("GH_REPO") == "" {
	if err := os.Setenv("GH_REPO", repoOverride); err != nil {
	// Non-fatal: the primary listing and download paths use explicit --repo flags.
	// Only gh api calls using {owner}/{repo} template placeholders (e.g. job status
	// queries) will be unable to resolve the repository context.
	logsOrchestratorLog.Printf("Failed to set GH_REPO env var (gh api {owner}/{repo} template calls may fail to resolve repo context): %v", err)
	}
	}
	}
	}
	// applyRepoOverrideFallback populates repoOverride from GITHUB_REPOSITORY when unset
	// and ensures GH_REPO is available for gh api {owner}/{repo} template expansion.
	func applyRepoOverrideFallback(repoOverride string) string {
	if repoOverride != "" {
	return repoOverride
	}
	githubRepo := os.Getenv("GITHUB_REPOSITORY")
	if githubRepo == "" {
	return repoOverride
	}
	repoOverride = githubRepo
	logsOrchestratorLog.Printf("Using GITHUB_REPOSITORY env var as repo override: %s", repoOverride)
	if os.Getenv("GH_REPO") == "" {
	if err := os.Setenv("GH_REPO", repoOverride); err != nil {
	// Non-fatal: the primary listing and download paths use explicit --repo flags.
	// Only gh api calls using {owner}/{repo} template placeholders (e.g. job status
	// queries) will be unable to resolve the repository context.
	logsOrchestratorLog.Printf("Failed to set GH_REPO env var (gh api {owner}/{repo} template calls may fail to resolve repo context): %v", err)
	}
	}
	return repoOverride
	}
	// DownloadWorkflowLogs downloads and analyzes workflow logs with metrics
	func DownloadWorkflowLogs(ctx context.Context, workflowName string, count int, startDate, endDate, outputDir, engine, ref string, beforeRunID, afterRunID int64, repoOverride string, verbose bool, toolGraph bool, noStaged bool, firewallOnly bool, noFirewall bool, parse bool, jsonOutput bool, timeout int, summaryFile string, safeOutputType string, filteredIntegrity bool, train bool, format string, artifactSets []string) error {
	repoOverride = applyRepoOverrideFallback(repoOverride)

[Copilot]

This PR adds a new top-level .mcp.json file, but the PR description only mentions changes to pkg/cli/logs_orchestrator.go. Please update the PR description to mention .mcp.json, or drop the file from this PR if it’s unrelated to the reported gh aw logs sandbox failure.

[pelikhan]

@copilot review comments

[Copilot]

@copilot review comments

Addressed all three review comments in commit 5004613:

1. Extracted applyRepoOverrideFallback helper — the fallback logic lives in its own function, making DownloadWorkflowLogs cleaner and the logic independently testable.

2. Scoped GH_REPO with defer — used os.LookupEnv to detect whether GH_REPO was already set (never overwrite), and defer os.Unsetenv to clean it up on function return, preventing cross-test contamination.

3. Added unit tests (TestApplyRepoOverrideFallback) covering all four scenarios: explicit override passthrough, GITHUB_REPOSITORY fallback + cleanup, pre-existing GH_REPO respected, and no env vars present. All pass.

4. Removed .mcp.json — it was unrelated to this fix.

[pelikhan]

@copilot do not set env, fail if needed

[Copilot]

@copilot do not set env, fail if needed

Done in e016b3a. applyRepoOverrideFallback now only reads GITHUB_REPOSITORY and returns the fallback string — no environment variables are set. If gh api {owner}/{repo} calls fail because git isn't available, they already return nil (non-fatal), so no change in observable behaviour for those paths.

[pelikhan]

@copilot review comments

[Copilot]

@copilot review comments

Code review ran clean — the only finding was about .mcp.json which was a stale staged file in the validation environment, not in the committed diff. The file is confirmed deleted from the branch. No other issues found.