chore(scale-set): docs and workflows changes - #5347
Open
edersonbrilhante wants to merge 11 commits into
Open
edersonbrilhante wants to merge 11 commits into
edersonbrilhante wants to merge 11 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
edersonbrilhante
marked this pull request as draft
September 3, 2026 21:28
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 8, 2026 15:28
17e79aa to
29a4b53
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 8, 2026 15:29
54a8eb3 to
1172732
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 8, 2026 20:04
29a4b53 to
81b05fd
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 8, 2026 20:04
1172732 to
cdca4dc
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 8, 2026 20:12
81b05fd to
266ffbe
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 8, 2026 20:12
cdca4dc to
d99f1f8
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 8, 2026 20:48
84e24df to
7a8548f
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 8, 2026 20:48
d99f1f8 to
4d9bfd0
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 10, 2026 16:55
7a8548f to
88d73fb
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 10, 2026 16:55
4d9bfd0 to
d568ef4
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 11, 2026 07:53
88d73fb to
7330164
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 11, 2026 07:53
d568ef4 to
aca1a4d
Compare
edersonbrilhante
had a problem deploying
to
release
September 11, 2026 22:59 — with
GitHub Actions
Failure
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 15, 2026 02:19
91d755a to
aca1a4d
Compare
edersonbrilhante
removed this pull request from stack #5348
September 15, 2026 09:57
edersonbrilhante
added this pull request to stack #5406
September 15, 2026 09:57
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 15, 2026 13:52
3023ad1 to
868e279
Compare
edersonbrilhante
removed this pull request from stack #5406
September 15, 2026 13:54
edersonbrilhante
added this pull request to stack #5432
September 15, 2026 13:55
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 15, 2026 13:56
aca1a4d to
9f0a3a9
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 16, 2026 11:26
b46fb11 to
c611851
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
2 times, most recently
from
September 16, 2026 15:23
5128d72 to
fb0c043
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 16, 2026 15:34
c611851 to
861c06d
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 16, 2026 22:08
fb0c043 to
f95f095
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 16, 2026 22:08
861c06d to
ca51c9c
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript
branch
from
September 16, 2026 22:11
f95f095 to
c215749
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 16, 2026 22:11
ca51c9c to
764f7d3
Compare
edersonbrilhante
force-pushed
the
feat-scale-set-typescript-docs-ci
branch
from
September 16, 2026 22:22
62187e3 to
a8a89d4
Compare
edersonbrilhante
removed this pull request from stack #5431
September 17, 2026 14:28
edersonbrilhante
added this pull request to stack #5437
September 17, 2026 14:38
edersonbrilhante
removed this pull request from stack #5437
September 17, 2026 18:20
edersonbrilhante
added this pull request to stack #5441
September 17, 2026 18:41
edersonbrilhante
removed this pull request from stack #5441
September 17, 2026 19:01
edersonbrilhante
added this pull request to stack #5442
September 17, 2026 19:01
edersonbrilhante
removed this pull request from stack #5442
September 17, 2026 21:40
edersonbrilhante
added this pull request to stack #5443
September 18, 2026 10:18
edersonbrilhante
removed this pull request from stack #5443
September 18, 2026 10:19
## Description Add the scale-set service-container smoke test and the ECS/MockServer scale-set lifecycle test on top of the scale-set Terraform wiring. - Build the scale-set service image from `lambdas/services/scale-set/Dockerfile`, push it to a MiniStack ECR repository, and allow the MiniStack account to pull it. - Run the controller through its real ECS container entrypoint with a read-only filesystem, dropped capabilities, and `no-new-privileges`. - Configure the scale-set example with the MockServer GitHub App/Actions endpoints and the required SSM-backed GitHub App values. - Verify the controller resolves the runner group and scale set, updates labels, creates a session, and reaches a converged state. - Start at `minRunners = 1`, verify MiniStack creates and registers the EC2 runner, then register a new ECS task definition with `minRunners = 0` and verify the controller removes the mocked GitHub runner and terminates the EC2 instance. - Keep the MockServer protocol fixture deterministic, including dynamic agent-name matching and runner/session cleanup. The workflow uses MiniStack 1.5.12 and a pinned MockServer image. The scale-set lifecycle integration remains in this PR; PR #5416 provides only the reusable example-fixture support. ## Test Plan - Full local MiniStack 1.5.12 lifecycle test passed: image build/ECR push, Terraform apply of 272 resources, ECS controller startup, scale-up runner registration, ECS redeployment with `minRunners = 0`, EC2 runner termination, MockServer session cleanup, and Terraform destroy. - `sh -n tests/ministack/run-scale-set-integration.sh` - `shellcheck -S warning tests/ministack/run-scale-set-integration.sh` - `python3 -m json.tool mockserver/initializerJson.json` - `terraform fmt -check examples/multi-runner-scale-set/main.tf examples/multi-runner-scale-set/variables.tf` - `git diff --check` ## Related Issues Depends on #5347. The Terraform wiring is provided by the scale-set stack beginning at #5350; the example is restored in #5405. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Guilherme Caulada <guilherme.caulada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the documentation, CI, release, and integration-test support needed to validate and publish the GitHub Actions scale-set service introduced by #5300.
This PR includes:
multi-runner-scale-setexample, validates the rendered SSM configuration and ECS task definition, exercises GitHub App and scale-set protocol requests, verifies runner launch and registration, changes the minimum capacity to zero, verifies scale-down and termination, and cleans up the deployment.gh attestation verifycommand for production image verification.Test Plan
linux/amd64andlinux/arm64.git diff --checkand the changed-file scope were verified for this follow-up branch.Related Issues