Skip to content

Run artifact uploads on Node 24 - #844

Open
flyingrobots wants to merge 1 commit into
mainfrom
maintenance/upload-artifact-node24
Open

Run artifact uploads on Node 24#844
flyingrobots wants to merge 1 commit into
mainfrom
maintenance/upload-artifact-node24

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • pin actions/upload-artifact to the immutable commit for official release v7.0.1, which declares a Node 24 runtime
  • update the Performance workflow's exact-pin regression contract
  • preserve artifact naming, source path, missing-file behavior, archive behavior, and 90-day retention

Issue

Closes #845

Test plan

  • focused Performance workflow tests: 5 passed
  • stable unit suite: 7,265 passed; 2 skipped
  • actionlint .github/workflows/performance.yml
  • npm run lint
  • npm run typecheck
  • anti-sludge, Semgrep, type-policy, quarantine-graduation, and commit/push hooks

ADR checks

  • This PR does not implement ADR 2 without satisfying ADR 3
  • This PR does not touch persisted op formats
  • This PR does not touch wire compatibility
  • This PR does not touch schema constants

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the performance reporting workflow to use a refreshed, securely pinned artifact upload action.
    • Performance artifacts continue to be collected under the same conditions, with unchanged naming, storage duration, and handling when files are unavailable.
    • Updated automated validation to reflect the workflow’s refreshed action version.

Walkthrough

The performance workflow now pins actions/upload-artifact to a new commit. The related unit test expects the same commit. Artifact upload settings remain unchanged.

Changes

Performance artifact pin

Layer / File(s) Summary
Update workflow pin and test expectation
.github/workflows/performance.yml, test/unit/scripts/performance-workflow.test.ts
The workflow uses commit 043fb46d1a93c77aae656e7c1c64a875d1fc6a0a, and the unit test expects this revision.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit checks the pinned line,
The artifact path stays just fine.
The test hops close behind,
One commit now aligned.
“Upload complete!” we cheer in time.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: updating artifact uploads to use Node 24.
Description check ✅ Passed The description includes the required summary, issue reference, test plan, and completed ADR checks.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Release Preflight

  • package version: 19.0.2
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If this PR is from a release/* branch and merges to main, Main Push Release Branch Check will run final preflight and create v19.0.2. A maintainer who is a JSR @git-stunts scope member must then dispatch the Release workflow manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run performance artifact uploads on Node 24

1 participant