Fix #368: prove upgrade entrypoint contract

[flyingrobots]

Summary

• replace raw package/tsconfig source-text checks with structured package and publish-config imports
• derive the built upgrade entrypoint from scripts.upgrade and verify its source is included by the publish build
• update the top-level v16-to-v17 upgrade test to use the same structured package contract

Closes #368

Validation

• npm exec vitest run test/unit/scripts/uniform-git-cas-closeout.test.ts test/unit/scripts/v16-to-v17-upgrade.test.ts
• npm run typecheck:test
• pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

[coderabbitai]

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12ad29be-b32c-4fe1-9255-82e924609295

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and d364eca.

📒 Files selected for processing (3)

• test/helpers/parseUpgradeCommandEntrypoint.ts
• test/unit/scripts/uniform-git-cas-closeout.test.ts
• test/unit/scripts/v16-to-v17-upgrade.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-368-upgrade-entrypoint-contract

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

[flyingrobots]

Code Lawyer Findings

@codex please confirm this review posture.

Severity	File	Lines	Type	Issue	Recommended mitigation prompt
P4 Minor	test/unit/scripts/uniform-git-cas-closeout.test.ts, test/unit/scripts/v16-to-v17-upgrade.test.ts	helper function	Duplication / parser looseness	Both tests define the same upgradeCommandEntrypoint() helper, and the helper accepts commands with extra && stages because it only reads the second split segment.	Extract a named parseUpgradeCommandEntrypoint(command: string) test helper, enforce exactly two command stages and a node second stage, then use it from both test files.

[flyingrobots]

Code Lawyer Activity Summary

@codex please confirm this closure.

Source	Severity	File	Lines	Issue	Commit	Outcome
Self	P4 Minor	test/unit/scripts/uniform-git-cas-closeout.test.ts, test/unit/scripts/v16-to-v17-upgrade.test.ts	helper function	Duplicate local upgradeCommandEntrypoint() helpers and parser accepted extra && stages.	d364ecaa	Extracted parseUpgradeCommandEntrypoint(command) into a concept-named test helper and made it enforce exactly two command stages plus a node entrypoint stage.

Validation:

• RED static check: rg -n "function upgradeCommandEntrypoint" test/unit/scripts/uniform-git-cas-closeout.test.ts test/unit/scripts/v16-to-v17-upgrade.test.ts
• GREEN static check: ! rg -n "function upgradeCommandEntrypoint" test/unit/scripts/uniform-git-cas-closeout.test.ts test/unit/scripts/v16-to-v17-upgrade.test.ts
• npm exec vitest run test/unit/scripts/uniform-git-cas-closeout.test.ts test/unit/scripts/v16-to-v17-upgrade.test.ts
• npm run typecheck:test
• npm run lint -- test/helpers/parseUpgradeCommandEntrypoint.ts test/unit/scripts/uniform-git-cas-closeout.test.ts test/unit/scripts/v16-to-v17-upgrade.test.ts
• git diff --check
• WARP_QUICK_PUSH=1 git push static pre-push gates 0-7 passed; unit gate intentionally skipped by quick mode.

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.