Skip to content

Fix domain profile selection when refreshing context menus - #2024

Merged
gildas-lormeau merged 1 commit into
gildas-lormeau:mainfrom
TXyy2023:codex/issue-1898-domain-profile-menu
Oct 18, 2026
Merged

gildas-lormeau merged 1 commit into
gildas-lormeau:mainfrom
TXyy2023:codex/issue-1898-domain-profile-menu

Conversation

@TXyy2023

Copy link
Copy Markdown
Contributor

When a global profile other than Default Settings is selected, activating a tab without a domain rule changes the domain-profile menu from - to Default Settings, even though saving still uses the global profile. The refresh path also treats wildcard rules as domain rules and loses an explicit - selection.

Match menu creation and rule editing by ignoring wildcard rules during the domain-menu refresh and selecting - when no domain rule exists. Explicit default, current, and named rules retain their selection and update-rule label. The checked-in background bundle is regenerated.

Addresses #1898 (the domain-profile menu). The separate observation about exporting the global profile selection is not changed here.

Validation on Node.js 26.12.0:

  • Seven regression scenarios exercise the actual config and menu modules using browser API fixtures: six failed and one passed before the fix; all seven pass after it.
  • npm ci, npx eslint ., and npm test (28 tests) pass.
  • ./build-extension.sh passes; a second ./build.sh leaves the committed build output unchanged.
  • CI ASCII and Woleet placeholder checks pass; the packaged source and background bundle match the checked-in files.

Native browser context-menu interaction was not tested. Codex assisted with the implementation and tests.

@gildas-lormeau

Copy link
Copy Markdown
Owner

Merged, thanks! The same code was in the MV3 version, so I ported the fix there too (gildas-lormeau/SingleFile-MV3@7fd42c2). It will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants